-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup(rules): graduate 'Disallowed SSH Connection Non Standard Port' to maturity_stable #158
Conversation
…' to maturity_stable Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
Rules files suggestionsfalco_rules.yamlComparing Major changes:
Minor changes:
Patch changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking the rule, it seems pretty accurate with low FPs. Agree on moving this rule!
LGTM!
LGTM label has been added. Git tree hash: 3ec84b35a6f639192a697f06adc69dd444c6f6e3
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: darryk10, incertum, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area rules
Proposed rule maturity level
/area maturity-stable
What this PR does / why we need it:
Graduating rule "Disallowed SSH Connection Non Standard Port" according to our assessment here #147 (review)
@darryk10 @Andreagit97
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: