-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(rules): Change namespace privileges via unshare #160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @incertum, the use case is awesome and checking the rule it seems pretty accurate with low FPs.
LGTM
LGTM label has been added. Git tree hash: ef0995f4d1b4bd7b063eb004cf93dc9db15d8e95
|
Co-authored-by: darryk10 <stefano.chierici@sysdig.com> Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
36bb9ff
to
6b1a9b4
Compare
LGTM label has been added. Git tree hash: c0668328313504ba333a829e9f32d51aa22679d5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, darryk10, incertum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
Because the memfd + exec rule made it already incompatible with 0.35. |
got it thanks! |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area rules
Proposed rule maturity level
/area maturity-incubating
What this PR does / why we need it:
See
desc
and also part of modernizing Falco rules #138.CC @darryk10 @Andreagit97
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: