Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): update latest even if higher prereleases are present #162

Merged
merged 1 commit into from
Sep 12, 2023
Merged

fix(build): update latest even if higher prereleases are present #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions build/registry/tag.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,22 +100,25 @@ func ociTagsToUpdate(newTag string, existingTags []string) []string {
return tagsToUpdate
}

var existingSemvers []semver.Version
var existingFinalSemvers []semver.Version
for _, tag := range existingTags {
if sv, err := semver.Parse(tag); err == nil {
existingSemvers = append(existingSemvers, sv)
// ignore prereleases
if len(sv.Pre) == 0 {
existingFinalSemvers = append(existingFinalSemvers, sv)
}
}
}

if isLatestSemverForMinor(newSemver, existingSemvers) {
if isLatestSemverForMinor(newSemver, existingFinalSemvers) {
tagsToUpdate = append(tagsToUpdate, fmt.Sprintf("%d.%d", newSemver.Major, newSemver.Minor))
}

if isLatestSemverForMajor(newSemver, existingSemvers) {
if isLatestSemverForMajor(newSemver, existingFinalSemvers) {
tagsToUpdate = append(tagsToUpdate, fmt.Sprintf("%d", newSemver.Major))
}

if isLatestSemver(newSemver, existingSemvers) {
if isLatestSemver(newSemver, existingFinalSemvers) {
tagsToUpdate = append(tagsToUpdate, "latest")
}

Expand Down
2 changes: 2 additions & 0 deletions build/registry/tag_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ func Test_ociTagsToUpdate(t *testing.T) {
{"latest_in_line", "0.1.3", []string{"0.1.2", "0.2.0", "0.3.1"}, []string{"0.1.3", "0.1"}},
{"version_1", "1.0.2", []string{"0.1.2", "0.2.0", "1.0.0", "2.0.0", "2.0.2"}, []string{"1", "1.0", "1.0.2"}},
{"prerelease", "0.1.4-rc1", []string{"0.1.2", "0.1.3"}, []string{"0.1.4-rc1"}},
{"latest_with_prerelease", "1.0.2", []string{"1.0.0", "1.0.1", "2.0.0-rc1"}, []string{"1", "1.0", "1.0.2", "latest"}},
{"not_latest_with_prerelease", "1.0.2", []string{"1.0.0", "1.0.1", "2.0.0-rc1", "2.0.0"}, []string{"1", "1.0", "1.0.2"}},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
Expand Down