Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vote: update(OWNERS): add loresuso to approvers #251

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

loresuso
Copy link
Member

@loresuso loresuso commented Jun 3, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

Proposed rule maturity level

Uncomment one (or more) /area <> lines (only for PRs that add or modify rules):

/area maturity-stable

/area maturity-incubating

/area maturity-sandbox

/area maturity-deprecated

What this PR does / why we need it:

Hello everyone,
I would like to propose myself as a Falco Rules maintainer. I've been involved in the project for two years and a half now, consistently helping review rules, proposing new ones, implementing some new fields for better detection, working on the CI of this repo for shipping rules as OCI artifacts, and also helping with the transition to a semver engine version. I would love to continue contributing as a maintainer of this repo :)

cc @falcosecurity/rules-maintainers to start the voting process!

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
@incertum
Copy link
Contributor

incertum commented Jun 4, 2024

Big +1 ❤️ finally Lorenzo -- a pleasure to have you on board as approver 😉

@FedeDP
Copy link
Contributor

FedeDP commented Jun 4, 2024

+1 from me! Welcome on board 🚢

@Andreagit97
Copy link
Member

Andreagit97 commented Jun 4, 2024

Big +1!

@leogr
Copy link
Member

leogr commented Jun 4, 2024

Ofc, huge +1 from me too 🤗

/hold until we reach the majority or a week has passed

@LucaGuerra
Copy link
Contributor

Big +1 🚀

@leogr leogr self-assigned this Jun 6, 2024
@darryk10
Copy link
Contributor

darryk10 commented Jun 6, 2024

big +1!!

@leogr
Copy link
Member

leogr commented Jun 12, 2024

With a lot of votes in favor and nobody against Majory vote has passed!

/unhold

🥳

@poiana poiana added the lgtm label Jun 12, 2024
@poiana
Copy link

poiana commented Jun 12, 2024

LGTM label has been added.

Git tree hash: 4470228b448d1fe8167ac49f65dd80e99caf90a7

@poiana
Copy link

poiana commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, loresuso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit c0a9bf1 into falcosecurity:main Jun 12, 2024
7 of 8 checks passed
@loresuso
Copy link
Member Author

Thank you all! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants