Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed output issues within the sandbox ruleset #255

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

darryk10
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

Proposed rule maturity level

Uncomment one (or more) /area <> lines (only for PRs that add or modify rules):

/area maturity-stable

/area maturity-incubating

/area maturity-sandbox

/area maturity-deprecated

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: Stefano Chierici <stefano.chierici@sysdig.com>

Signed-off-by: schie <77834235+darryk10@users.noreply.github.com>
Copy link

Rules files suggestions

falco-sandbox_rules.yaml

Comparing e43e31a6a8027d0a34902a5adaf42c23f0f42e38 with latest tag falco-sandbox-rules-4.0.0

Patch changes:

  • Rule Unexpected inbound connection source changed its output fields
  • Rule Interpreted procs inbound network activity changed its output fields
  • Rule Interpreted procs outbound network activity changed its output fields
  • Rule Unexpected K8s NodePort Connection changed its output fields
  • Rule Detect outbound connections to common miner pool ports changed its output fields
  • Rule Java Process Class File Download changed its output fields

Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks, huh it's complete?

@poiana
Copy link

poiana commented Jun 27, 2024

LGTM label has been added.

Git tree hash: 799ee826b5913c2fa5dea02b26d8db6e6d1c05dd

@poiana
Copy link

poiana commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: darryk10, incertum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 28b98b6 into main Jun 27, 2024
7 of 9 checks passed
@poiana poiana deleted the darryk10-patch-1 branch June 27, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants