Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(incubating_rules): revert #508 #257

Merged
merged 2 commits into from
Aug 2, 2024
Merged

fix(incubating_rules): revert #508 #257

merged 2 commits into from
Aug 2, 2024

Conversation

LucaGuerra
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

Proposed rule maturity level

Uncomment one (or more) /area <> lines (only for PRs that add or modify rules):

/area maturity-incubating

What this PR does / why we need it:

In #208 we changed the type of the cmd argument to a flag type because of changes in falcosecurity/libs#1545 , however the libs PR was only modifying the exit event, while this rule refers to the enter event which is still an INT64, thus we still need to use the value 5 for this event. I noticed this during a conversation with @incertum .

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana poiana added dco-signoff: yes kind/bug Something isn't working area/rules area/maturity-incubating See the Rules Maturity Framework size/XS labels Aug 2, 2024
@poiana poiana added the approved label Aug 2, 2024
Copy link

github-actions bot commented Aug 2, 2024

Rules files suggestions

falco-incubating_rules.yaml

Comparing 6a0922b6879c309f75bc82e644f2e9918310f7cc with latest tag falco-incubating-rules-4.0.0

Patch changes:

  • Rule System procs network activity changed its output fields
  • Rule Unexpected UDP Traffic changed its output fields
  • Rule Contact EC2 Instance Metadata Service From Container changed its output fields
  • Rule Contact cloud metadata service from container changed its output fields
  • Rule Network Connection outside Local Subnet changed its output fields

@poiana
Copy link

poiana commented Aug 2, 2024

LGTM label has been added.

Git tree hash: 70cc2fad124907902448783fa9a806dc51f084bf

incertum
incertum previously approved these changes Aug 2, 2024
Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

ohhh, ty!

@incertum
Copy link
Contributor

incertum commented Aug 2, 2024

/hold

@incertum
Copy link
Contributor

incertum commented Aug 2, 2024

@LucaGuerra mind also updating the description?

Copy link

github-actions bot commented Aug 2, 2024

Rules files suggestions

falco-incubating_rules.yaml

Comparing c2e6007b0de8268dda3cb4f3da33f858ca774568 with latest tag falco-incubating-rules-4.0.0

Patch changes:

  • Rule System procs network activity changed its output fields
  • Rule Unexpected UDP Traffic changed its output fields
  • Rule Contact EC2 Instance Metadata Service From Container changed its output fields
  • Rule Contact cloud metadata service from container changed its output fields
  • Rule Network Connection outside Local Subnet changed its output fields

Signed-off-by: Luca Guerra <luca@guerra.sh>
Signed-off-by: Luca Guerra <luca@guerra.sh>
Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/unhold

@poiana
Copy link

poiana commented Aug 2, 2024

LGTM label has been added.

Git tree hash: 4a03117c5fb4a724568384a70987799fb08cec5a

@poiana
Copy link

poiana commented Aug 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: incertum, loresuso, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 342b20d into main Aug 2, 2024
7 of 8 checks passed
@poiana poiana deleted the LucaGuerra-patch-2 branch August 2, 2024 16:00
Copy link

github-actions bot commented Aug 2, 2024

Rules files suggestions

falco-incubating_rules.yaml

Comparing 42bf4c83e67e7565174e6fd76d33ac82b16c4018 with latest tag falco-incubating-rules-4.0.0

Patch changes:

  • Rule System procs network activity changed its output fields
  • Rule Unexpected UDP Traffic changed its output fields
  • Rule Contact EC2 Instance Metadata Service From Container changed its output fields
  • Rule Contact cloud metadata service from container changed its output fields
  • Rule Network Connection outside Local Subnet changed its output fields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants