Skip to content

Commit

Permalink
fix: use window.open for mobile links (#217)
Browse files Browse the repository at this point in the history
## Change Summary

Follow up to #200. Add changeset, use `window.open` in `SignInButton`.

## Merge Checklist

_Choose all relevant options below by adding an `x` now or at any time
before submitting for review_

- [x] PR title adheres to the [conventional
commits](https://www.conventionalcommits.org/en/v1.0.0/) standard
- [x] PR has a changeset
- [x] PR has been tagged with a change label(s) (i.e. documentation,
feature, bugfix, or chore)
- [ ] PR includes documentation if necessary
- [x] All commits have been signed
  • Loading branch information
horsefacts authored Aug 22, 2024
1 parent 99664c1 commit 782c742
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/mean-baboons-collect.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@farcaster/auth-kit": patch
---

fix: use window.open for mobile links
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export function SignInButton({
setShowDialog(true);
signIn();
if (url && isMobile()) {
window.location.href = url;
window.open(url, "_blank");
}
}, [isError, reconnect, signIn, url]);

Expand Down

0 comments on commit 782c742

Please sign in to comment.