fix: remove qrCodeUri (#131)

* fix: remove qrCodeUri * chore: bump versions
farcasterxyz · Jan 29, 2024 · 7b3a884 · 7b3a884
1 parent 713a933
commit 7b3a884
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 15 deletions.
diff --git a/packages/auth-kit/CHANGELOG.md b/packages/auth-kit/CHANGELOG.md
@@ -1,5 +1,11 @@
 # @farcaster/auth-kit
 
+## 0.2.0
+
+### Minor Changes
+
+- fix: remove qrCodeUri return value
+
 ## 0.1.4
 
 ### Patch Changes

diff --git a/packages/auth-kit/README.md b/packages/auth-kit/README.md
@@ -154,12 +154,12 @@ export const SignIn = ({ nonce }: { nonce: string }) => {
 Hook for signing in a user. Connects to the relay server, generates a QR code and sign in link to present to the user, and polls relay server for wallet signature.
 
 ```tsx
-import { useSignIn } from "@farcaster/auth-kit";
+import { QRCode, useSignIn } from "@farcaster/auth-kit";
 
 function App() {
   const {
     signIn,
-    qrCodeUri,
+    url
     data: { username },
     onSuccess: ({ fid }) => console.log("Your fid:", fid);
   } = useSignIn();
@@ -169,7 +169,7 @@ function App() {
       <button onClick={signIn}>Sign In</button>
       {qrCodeUri && (
         <span>
-          Scan this: <img src={qrCodeUri} />
+          Scan this: <QRCode uri={url} />
         </span>
       )}
       {username && `Hello, ${username}!`}

diff --git a/packages/auth-kit/package.json b/packages/auth-kit/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@farcaster/auth-kit",
-  "version": "0.1.4",
+  "version": "0.2.0",
   "type": "module",
   "main": "./dist/auth-kit.js",
   "types": "./dist/auth-kit.d.ts",

diff --git a/packages/auth-kit/src/components/index.ts b/packages/auth-kit/src/components/index.ts
@@ -1,3 +1,4 @@
 export * from "./SignInButton";
 export * from "./AuthKitProvider";
 export * from "./Demo";
+export * from "./QRCode";
diff --git a/packages/auth-kit/src/hooks/useCreateChannel.ts b/packages/auth-kit/src/hooks/useCreateChannel.ts
@@ -1,4 +1,3 @@
-import QRCode from "qrcode";
 import { AuthClientError } from "@farcaster/auth-client";
 import { useCallback, useEffect, useState } from "react";
 
@@ -18,7 +17,6 @@ export interface UseCreateChannelData {
   channelToken?: string;
   url?: string;
   nonce?: string;
-  qrCodeUri?: string;
 }
 
 export function useCreateChannel({
@@ -34,7 +32,6 @@ export function useCreateChannel({
   const appClient = useAppClient();
 
   const [connected, setConnected] = useState<boolean>(false);
-  const [qrCodeUri, setqrCodeUri] = useState<string>();
   const [channelToken, setChannelToken] = useState<string>();
   const [url, setUrl] = useState<string>();
   const [nonce, setNonce] = useState<string>();
@@ -67,10 +64,8 @@ export function useCreateChannel({
         setUrl(url);
         setNonce(nonce);
 
-        const qrCodeUri = await QRCode.toDataURL(url, { width: 360 });
-        setqrCodeUri(qrCodeUri);
         setIsSuccess(true);
-        onSuccess?.({ channelToken, url, qrCodeUri, nonce });
+        onSuccess?.({ channelToken, url, nonce });
       }
     }
   }, [
@@ -98,11 +93,10 @@ export function useCreateChannel({
   const reset = useCallback(() => {
     setChannelToken(undefined);
     setUrl(undefined);
-    setqrCodeUri(undefined);
     setIsSuccess(false);
     setIsError(false);
     setError(undefined);
-  }, [setChannelToken, setUrl, setqrCodeUri, setIsSuccess, setIsError, setError]);
+  }, [setChannelToken, setUrl, setIsSuccess, setIsError, setError]);
 
   const reconnect = useCallback(() => {
     reset();
@@ -116,7 +110,7 @@ export function useCreateChannel({
     isSuccess,
     isError,
     error,
-    data: { channelToken, url, qrCodeUri, nonce },
+    data: { channelToken, url, nonce },
   };
 }
 

diff --git a/packages/auth-kit/src/hooks/useSignIn.ts b/packages/auth-kit/src/hooks/useSignIn.ts
@@ -38,7 +38,7 @@ export function useSignIn(args: UseSignInArgs) {
     connect,
     reconnect,
     reset,
-    data: { channelToken, url, qrCodeUri, nonce },
+    data: { channelToken, url, nonce },
     isSuccess: isConnected,
     isError: isCreateChannelError,
     error: createChannelError,
@@ -102,7 +102,6 @@ export function useSignIn(args: UseSignInArgs) {
     error,
     channelToken,
     url,
-    qrCodeUri,
     appClient,
     data: statusData,
     validSignature,