Skip to content

Commit

Permalink
chore: use window.open instead to prevent listener page from closing (
Browse files Browse the repository at this point in the history
#200)

## Motivation

https://warpcast.com/andrei0x309/0x176bd96f

## Change Summary

Minimal change that uses `window.open` instead of `window.location`. 
Changes how the mobile deep link is open to increase device
compatibility, especially on Android.

## Merge Checklist

_Choose all relevant options below by adding an `x` now or at any time
before submitting for review_

- [x] PR title adheres to the [conventional
commits](https://www.conventionalcommits.org/en/v1.0.0/) standard
- [ ] PR has a changeset
- [x] PR has been tagged with a change label(s) (i.e. documentation,
feature, bugfix, or chore)
- [x] PR includes documentation if necessary
- [x] All commits have been signed

## Additional Context

If this is a relatively large or complex change, provide more details
here that will help reviewers
  • Loading branch information
andrei0x309 committed Aug 22, 2024
1 parent dbd3ce8 commit 99664c1
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export function QRCodeDialog({
fontWeight: 500,
}}
onClick={() => {
window.location.href = url;
window.open(url, "_blank");
}}
>
<svg
Expand Down

0 comments on commit 99664c1

Please sign in to comment.