Skip to content

Commit

Permalink
fix: farcaster logo viewbox (#144)
Browse files Browse the repository at this point in the history
## Motivation

The `FarcasterLogo` svg file doesn't have `viewBox` property set,
therefore with default `logoSize = 50` being used in `QRCode` component,
it scales incorrectly.
## Change Summary

Added viewbox property to the svg that matches the path height and size
set in farcaster svg.

## Merge Checklist

_Choose all relevant options below by adding an `x` now or at any time
before submitting for review_

- [x] PR title adheres to the [conventional
commits](https://www.conventionalcommits.org/en/v1.0.0/) standard
- [x] PR has a changeset
- [x] PR has been tagged with a change label(s) (i.e. documentation,
feature, bugfix, or chore)
- [x] PR includes documentation if necessary
- [x] All commits have been signed

## Additional Context

If this is a relatively large or complex change, provide more details
here that will help reviewers

Before:
![Screenshot 2024-02-15 at 14 34
51](https://github.com/farcasterxyz/auth-monorepo/assets/35642018/55e68b3e-ff81-4ce8-852a-26d3863a0fac)
After:
![Screenshot 2024-02-15 at 14 35
25](https://github.com/farcasterxyz/auth-monorepo/assets/35642018/3377c7e2-cbeb-4210-8410-e3e158525c22)
  • Loading branch information
dalechyn committed Aug 14, 2024
1 parent f0fc335 commit 9d4371f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/curvy-bikes-lick.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@farcaster/auth-kit": patch
---

Fixed Farcaster SVG Logo missing `viewBox` property that led to incorrect logo render.
1 change: 1 addition & 0 deletions packages/auth-kit/src/components/FarcasterLogo.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export function FarcasterLogo({
height={height}
viewBox="0 0 22 20"
fill="none"
viewBox="0 0 22 20"
>
<title>Farcaster logo</title>
<g fill={fillColor[fill]} clipPath="url(#a)">
Expand Down

0 comments on commit 9d4371f

Please sign in to comment.