From 9d4371f8b84eff1e7ae2290da46bc988eac28965 Mon Sep 17 00:00:00 2001 From: Vladyslav Dalechyn Date: Wed, 14 Aug 2024 20:25:11 +0300 Subject: [PATCH] fix: farcaster logo viewbox (#144) ## Motivation The `FarcasterLogo` svg file doesn't have `viewBox` property set, therefore with default `logoSize = 50` being used in `QRCode` component, it scales incorrectly. ## Change Summary Added viewbox property to the svg that matches the path height and size set in farcaster svg. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a changeset - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [x] PR includes documentation if necessary - [x] All commits have been signed ## Additional Context If this is a relatively large or complex change, provide more details here that will help reviewers Before: ![Screenshot 2024-02-15 at 14 34 51](https://github.com/farcasterxyz/auth-monorepo/assets/35642018/55e68b3e-ff81-4ce8-852a-26d3863a0fac) After: ![Screenshot 2024-02-15 at 14 35 25](https://github.com/farcasterxyz/auth-monorepo/assets/35642018/3377c7e2-cbeb-4210-8410-e3e158525c22) --- .changeset/curvy-bikes-lick.md | 5 +++++ packages/auth-kit/src/components/FarcasterLogo.tsx | 1 + 2 files changed, 6 insertions(+) create mode 100644 .changeset/curvy-bikes-lick.md diff --git a/.changeset/curvy-bikes-lick.md b/.changeset/curvy-bikes-lick.md new file mode 100644 index 0000000..eb2d1c0 --- /dev/null +++ b/.changeset/curvy-bikes-lick.md @@ -0,0 +1,5 @@ +--- +"@farcaster/auth-kit": patch +--- + +Fixed Farcaster SVG Logo missing `viewBox` property that led to incorrect logo render. diff --git a/packages/auth-kit/src/components/FarcasterLogo.tsx b/packages/auth-kit/src/components/FarcasterLogo.tsx index 40b916b..38f82d3 100644 --- a/packages/auth-kit/src/components/FarcasterLogo.tsx +++ b/packages/auth-kit/src/components/FarcasterLogo.tsx @@ -14,6 +14,7 @@ export function FarcasterLogo({ height={height} viewBox="0 0 22 20" fill="none" + viewBox="0 0 22 20" > Farcaster logo