Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: window conditional bug #128

Merged
merged 3 commits into from
Jan 27, 2024
Merged

fix: window conditional bug #128

merged 3 commits into from
Jan 27, 2024

Conversation

horsefacts
Copy link
Collaborator

@horsefacts horsefacts commented Jan 27, 2024 •
edited
Loading

Change Summary

Check for both window and window.location.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

  • PR title adheres to the conventional commits standard
  • PR has a changeset
  • PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore)
  • PR includes documentation if necessary
  • All commits have been signed

@horsefacts horsefacts added the bug label Jan 27, 2024
@horsefacts horsefacts merged commit 90e0966 into main Jan 27, 2024
3 checks passed
@horsefacts horsefacts deleted the horsefacts/window-conditional-bug branch August 19, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@horsefacts