Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
useCreateChannel
anduseSignIn
hooks convert the auth relay connection URL to a QR code and return it encoded as a data URI. However, the underlying library uses the Canvas API and is incompatible with React Native.AuthKit components don't actually use this internally, instead we use the unencoded
url
to create a QR code SVG. Although returning this value might be convenient, it probably doesn't belong at the hook level: clients should use a QR code library of their choice to render theurl
as a scannable code (or use theQRCode
component included in AuthKit).Change Summary
Remove
qrCodeUri
from the return value ofuseCreateChannel
anduseSignIn
.Export
QRCode
component.Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for review