Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: farcaster logo viewbox #144

Merged
merged 2 commits into from
Aug 14, 2024
Merged

fix: farcaster logo viewbox #144

merged 2 commits into from
Aug 14, 2024

Conversation

dalechyn
Copy link
Collaborator

@dalechyn dalechyn commented Feb 15, 2024

Motivation

The FarcasterLogo svg file doesn't have viewBox property set, therefore with default logoSize = 50 being used in QRCode component, it scales incorrectly.

Change Summary

Added viewbox property to the svg that matches the path height and size set in farcaster svg.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

  • PR title adheres to the conventional commits standard
  • PR has a changeset
  • PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore)
  • PR includes documentation if necessary
  • All commits have been signed

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers

Before:
Screenshot 2024-02-15 at 14 34 51
After:
Screenshot 2024-02-15 at 14 35 25

@dalechyn
Copy link
Collaborator Author

I have some other thoughts to suggest besides this PR which I addressed in your tg @horsefacts as I can't see Discussions enabled here in the repo :(.

dalechyn and others added 2 commits August 14, 2024 10:24
The `FarcasterLogo` svg file doesn't have `viewBox` property set, therefore with default `logoSize = 50` being used in `QRCode` component, it scales incorrectly.
@horsefacts horsefacts merged commit 9d4371f into farcasterxyz:main Aug 14, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants