Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[relay, auth-kit, auth-client] feat: support redirectUrl #157

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

deodad
Copy link
Member

@deodad deodad commented Apr 17, 2024

Motivation

Allow mobile apps using the connect flow to instruct wallet clients to return the user back to the app after signing.

Change Summary

  • support redirectUrl when initiating a sign in
  • remove ethers as a hard dependency from auth-client
  • add an expo example application

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

  • PR title adheres to the conventional commits standard
  • PR has a changeset
  • PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore)
  • PR includes documentation if necessary
  • All commits have been signed

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers

@deodad deodad force-pushed the td/relay-redirect-url branch 2 times, most recently from 661e88a to f450243 Compare April 17, 2024 19:13
@deodad deodad merged commit 62874a0 into main Apr 17, 2024
3 checks passed
@deodad deodad deleted the td/relay-redirect-url branch April 17, 2024 19:21
@dalechyn
Copy link
Collaborator

hey, that's probably a bit too late to comment, but why ethers was added as a peer dep when public provider can be used from viem directly?

@deodad
Copy link
Member Author

deodad commented Apr 18, 2024

@dalechyn ethers is a dependency of the siwe package

@deodad
Copy link
Member Author

deodad commented Apr 18, 2024

@dalechyn I saw some of your other comments, thank you—responded to some but feel free to open a concise PR with the others

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants