chore: use window.open instead to prevent listener page from closing
#200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
horsefacts
added a commit
that referenced
this pull request
Aug 22, 2024
## Change Summary Follow up to #200. Add changeset, use `window.open` in `SignInButton`. ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a changeset - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes documentation if necessary - [x] All commits have been signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://warpcast.com/andrei0x309/0x176bd96f
Change Summary
Minimal change that uses
window.openinstead ofwindow.location.Changes how the mobile deep link is open to increase device compatibility, especially on Android.
Merge Checklist
Choose all relevant options below by adding an
xnow or at any time before submitting for reviewAdditional Context
If this is a relatively large or complex change, provide more details here that will help reviewers