feat: add request metadata to channel #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horsefacts
force-pushed
the
horsefacts/add-user-agent-origin-ip
branch
from
53c46a1
to
c63ba11
Compare
horsefacts
force-pushed
the
horsefacts/add-user-agent-origin-ip
branch
from
c63ba11
to
2b20755
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To defend against “QR-jacking” attacks, pass the user agent and origin IP of the application opening the channel through the relay. Wallet clients can display this along with the sign in request, e.g. “requested from Chrome browser (Brooklyn, NY)” or similar.
Change Summary
Add
metadata.ipandmetadata.userAgentto relay session body.Merge Checklist
Choose all relevant options below by adding an
xnow or at any time before submitting for review