From a8736e1de76e3366de9e4f6e2dab9d415752fe25 Mon Sep 17 00:00:00 2001 From: Patrice ORENES-LERMA Date: Wed, 2 Oct 2024 23:42:01 +0200 Subject: [PATCH] fix(core): add faker back as a dependency as it is used (#2201) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Why is this change needed? Faker has been removed from the dependencies on the farcaster/core library by mistake, as it is used in factory.ts . Re-introducing it will prevent if from being bundled. Fixes #2031 ## Merge Checklist _Choose all relevant options below by adding an `x` now or at any time before submitting for review_ - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [x] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [x] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. --- ## PR-Codex overview This PR re-introduces the `faker` dependency in the `@farcaster/core` package. ### Detailed summary - Re-added `@faker-js/faker` dependency in `@farcaster/core` package.json - Removed `@faker-js/faker` from devDependencies > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` --- .changeset/honest-students-relax.md | 5 +++++ packages/core/package.json | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 .changeset/honest-students-relax.md diff --git a/.changeset/honest-students-relax.md b/.changeset/honest-students-relax.md new file mode 100644 index 0000000000..a4547b222e --- /dev/null +++ b/.changeset/honest-students-relax.md @@ -0,0 +1,5 @@ +--- +"@farcaster/core": minor +--- + +re-introducing faker dependency diff --git a/packages/core/package.json b/packages/core/package.json index 8639a091b3..01d63ee703 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -24,7 +24,9 @@ "@noble/hashes": "^1.3.0", "bs58": "^5.0.0", "neverthrow": "^6.0.0", + "@faker-js/faker": "^7.6.0", "viem": "^2.17.4" + }, "scripts": { "build": "tsup --config tsup.config.ts", @@ -38,7 +40,6 @@ }, "devDependencies": { "@ethersproject/abstract-signer": "^5.7.0", - "@faker-js/faker": "^7.6.0", "@farcaster/fishery": "2.2.3", "@noble/ed25519": "^1.7.3", "biome-config-custom": "*",