Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support bulk message RPC #2313

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Conversation

CassOnMars
Copy link
Member

@CassOnMars CassOnMars commented Sep 13, 2024

Why is this change needed?

Reconciliation of messages historically from off-hub sources is achieved via submitMessage, which incurs a performance penalty when many of these calls are made in rapid succession. This change introduces a new submitBulkMessages RPC which allows many of the to-be reconciled messages to be submitted at once and handle via the more efficient rust mergeMany underlying call.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR adds a new gRPC method SubmitBulkMessages for submitting multiple messages at once and updates related proto files and service implementations.

Detailed summary

  • Added SubmitBulkMessages gRPC method
  • Defined new message types: SubmitBulkMessagesRequest, MessageError, BulkMessageResponse, SubmitBulkMessagesResponse
  • Updated service implementations and proto files
  • Implemented server-side logic for SubmitBulkMessages
  • Added encoding and decoding functions for new message types

The following files were skipped due to too many changes: packages/hub-web/src/generated/request_response.ts, packages/hub-nodejs/src/generated/request_response.ts, packages/core/src/protobufs/generated/request_response.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 5:34am

Copy link

changeset-bot bot commented Sep 13, 2024

🦋 Changeset detected

Latest commit: f71136f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@farcaster/hub-nodejs Patch
@farcaster/hub-web Patch
@farcaster/core Patch
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CassOnMars CassOnMars added the t-feat Add a new feature or protocol improvement label Sep 17, 2024
@CassOnMars CassOnMars marked this pull request as ready for review September 17, 2024 05:34
@CassOnMars CassOnMars merged commit e5a8611 into main Sep 17, 2024
8 checks passed
@CassOnMars CassOnMars deleted the cassie-heart/many-messages-written branch September 17, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-feat Add a new feature or protocol improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant