Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix flaky test #2314

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix: Fix flaky test #2314

merged 1 commit into from
Sep 16, 2024

Conversation

sanjayprabhu
Copy link
Contributor

@sanjayprabhu sanjayprabhu commented Sep 16, 2024

Why is this change needed?

Fix flaky timestamp test that was relying expiry instead of blockTimestamp for storage rent.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

The focus of this PR is to update the storage cache test by adjusting the values of units and legacy_units.

Detailed summary

  • Updated units and legacy_units values in the storage cache test
  • Added blockTimestamp to storageRentEvent

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@sanjayprabhu sanjayprabhu added the t-bug A fix for a bug with the current system label Sep 16, 2024
Copy link

changeset-bot bot commented Sep 16, 2024

⚠️ No Changeset found

Latest commit: d06d182

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 9:25pm

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.43%. Comparing base (1880070) to head (d06d182).
Report is 350 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2314       +/-   ##
===========================================
- Coverage   74.05%   44.43%   -29.63%     
===========================================
  Files          99      146       +47     
  Lines        9425    25563    +16138     
  Branches     2097     9164     +7067     
===========================================
+ Hits         6980    11358     +4378     
- Misses       2327    12391    +10064     
- Partials      118     1814     +1696     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanjayprabhu sanjayprabhu merged commit 0a655b9 into farcasterxyz:main Sep 16, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-bug A fix for a bug with the current system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants