fix: Ignore local/loopback traffic in IP connection limiter #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: fd19441 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sanjayprabhu
approved these changes
Sep 26, 2024
apps/hubble/src/rpc/server.ts
Outdated
| @@ -319,7 +319,7 @@ class IpConnectionLimiter { | |||
| const ip = extractIPAddress(peerString) ?? "unknown"; | |||
|
|
|||
| const connections = this.ipConnections.get(ip) ?? 0; | |||
| if (connections >= this.perIpLimit) { | |||
| if (ip !== "127.0.0.1" && connections >= this.perIpLimit) { | |||
There was a problem hiding this comment.
It's a fair point, I just don't think people are using IPV6 for loopback communication. I'll follow up however.
There was a problem hiding this comment.
Added IPv6 loopback IP to the list.
This allows the use of reverse proxies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change needed?
This allows the use of reverse proxies.
Merge Checklist
PR-Codex overview
This PR focuses on enhancing the connection limiting functionality by ignoring local loopback IP traffic and modifying a test case.
Detailed summary
rateLimits.tsto ignore both127.0.0.1and::1for local loopback traffic.server.tsto exclude local IPs from the limit enforcement.eventService.test.tsto skip the test case for excessive subscriptions.