Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add contact info to sync health logs #2336

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

aditiharini
Copy link
Contributor

@aditiharini aditiharini commented Sep 26, 2024

Add more data to validate whether hubs are connecting to the correct IP addresses and ports.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR focuses on enhancing the logging of sync health jobs by adding contact information related to peers in the logs, which aids in troubleshooting.

Detailed summary

  • Added contactInfoForLogs method in syncHealthJob.ts to retrieve contact information for peers.
  • Updated the logging in doJobs method to include contact info when an error occurs during sync health computation.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Sep 26, 2024

🦋 Changeset detected

Latest commit: a2efe26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 6:11pm

@aditiharini aditiharini added the t-chore Miscellaneous improvements label Sep 26, 2024
@aditiharini aditiharini changed the title feat: add contact info to sync health logs chore: add contact info to sync health logs Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 34.17%. Comparing base (1880070) to head (a2efe26).
Report is 370 commits behind head on main.

Files with missing lines Patch % Lines
apps/hubble/src/network/sync/syncHealthJob.ts 0.00% 8 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (1880070) and HEAD (a2efe26). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1880070) HEAD (a2efe26)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2336       +/-   ##
===========================================
- Coverage   74.05%   34.17%   -39.89%     
===========================================
  Files          99      146       +47     
  Lines        9425    25646    +16221     
  Branches     2097     9116     +7019     
===========================================
+ Hits         6980     8765     +1785     
- Misses       2327    14862    +12535     
- Partials      118     2019     +1901     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aditiharini aditiharini merged commit 2717d44 into farcasterxyz:main Sep 26, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-chore Miscellaneous improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant