-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: turn sync health contact info into string before logging #2337
Conversation
🦋 Changeset detectedLatest commit: 7afa1b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2337 +/- ##
===========================================
- Coverage 74.05% 34.68% -39.38%
===========================================
Files 99 146 +47
Lines 9425 26013 +16588
Branches 2097 9119 +7022
===========================================
+ Hits 6980 9022 +2042
- Misses 2327 15238 +12911
- Partials 118 1753 +1635 ☔ View full report in Codecov by Sentry. |
Contact info appears as "Object" in the logs because it isn't translated into a string prior to logging.
Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewPR-Codex overview
This PR focuses on enhancing the
syncHealthJob
by adding functionality to serialize contact information into a string format before logging, improving the clarity and usability of logs related to synchronization health.Detailed summary
addressInfoFromGossip
andaddressInfoToString
from../../utils/p2p.js
.rpcAddress
fromcontactInfo
.addressInfo
and return a string representation of the address if successful.