fix: make the contact info logs for the sync health job richer #2338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently hard to tell what state the contact info is in if the rpc address is not present. Differentiate the error states better in the logging.
Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewPR-Codex overview
This PR focuses on improving error handling and simplifying the return values related to
contactInfo
in thesyncHealthJob.ts
file.Detailed summary
undefined
whencontactInfo
is missing with returning the string"Missing contact info"
.contactInfo
to directly returncontactInfo.contactInfo
.contactInfo
details in the logging.