Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make the contact info logs for the sync health job richer #2338

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

aditiharini
Copy link
Contributor

@aditiharini aditiharini commented Sep 26, 2024

It's currently hard to tell what state the contact info is in if the rpc address is not present. Differentiate the error states better in the logging.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR focuses on improving error handling and simplifying the return values related to contactInfo in the syncHealthJob.ts file.

Detailed summary

  • Replaced returning undefined when contactInfo is missing with returning the string "Missing contact info".
  • Changed the return value for contactInfo to directly return contactInfo.contactInfo.
  • Updated the error message to exclude contactInfo details in the logging.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Sep 26, 2024

⚠️ No Changeset found

Latest commit: 096cb21

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 10:42pm

@aditiharini aditiharini added the t-bug A fix for a bug with the current system label Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 45.58%. Comparing base (1880070) to head (096cb21).
Report is 378 commits behind head on main.

Files with missing lines Patch % Lines
apps/hubble/src/network/sync/syncHealthJob.ts 0.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (1880070) and HEAD (096cb21). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1880070) HEAD (096cb21)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2338       +/-   ##
===========================================
- Coverage   74.05%   45.58%   -28.48%     
===========================================
  Files          99      123       +24     
  Lines        9425    18062     +8637     
  Branches     2097     5633     +3536     
===========================================
+ Hits         6980     8233     +1253     
- Misses       2327     9827     +7500     
+ Partials      118        2      -116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aditiharini aditiharini merged commit 8f4e8e4 into farcasterxyz:main Sep 26, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-bug A fix for a bug with the current system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant