Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable logging for rpcs #2348

Closed

Conversation

aditiharini
Copy link
Contributor

@aditiharini aditiharini commented Oct 2, 2024

Why is this change needed?

Describe why this issue should be fixed and link to any relevant design docs, issues or other relevant items.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR focuses on enhancing logging within the Server class of the hubble application by replacing logger with log for consistency and changing debug logs to info logs for better visibility of RPC call activities.

Detailed summary

  • Replaced logger with log in various locations for consistency.
  • Changed log.debug statements to log.info to increase visibility for RPC call activities.
  • Added error logging in destroyStream function for better error tracking.
  • Updated log messages for clarity and detail during RPC calls.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Oct 2, 2024

⚠️ No Changeset found

Latest commit: 544f18c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 7:11pm

@sds
Copy link
Member

sds commented Oct 17, 2024

Closing due to rebase conflicts and age. Feel free to reopen if still relevant!

@sds sds closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants