Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore start/stop time for reconcileMessagesForFid #2351

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

CassOnMars
Copy link
Member

@CassOnMars CassOnMars commented Oct 2, 2024

Why is this change needed?

Restores start/stop time to reconcileMessagesForFid, possibly related to #2346.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR focuses on restoring the start and stop timestamps in the reconcileMessagesForFid function to improve message reconciliation functionality.

Detailed summary

  • Updated the function call in packages/shuttle/src/shuttle/messageReconciliation.ts to include startTimestamp and stopTimestamp parameters in allHubMessagesOfTypeForFid.
  • Added a fix note in the changelog for restoring the functionality.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@CassOnMars CassOnMars added the t-bug A fix for a bug with the current system label Oct 2, 2024
Copy link

changeset-bot bot commented Oct 2, 2024

🦋 Changeset detected

Latest commit: 67ad69e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/shuttle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 10:28pm

@CassOnMars CassOnMars enabled auto-merge (squash) October 2, 2024 22:36
@CassOnMars CassOnMars merged commit 8dfe984 into main Oct 2, 2024
8 checks passed
@CassOnMars CassOnMars deleted the cassie-heart/restore-start-stop-time branch October 2, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-bug A fix for a bug with the current system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants