feat(shuttle): Pipe connectionTimeout arg through EventStreamHubSubscriber #2382
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change needed?
Follow-up to #2367. I missed piping through BaseHubSubscriber's new
connectionTimeout
param through to EventStreamHubSubscriber, which meansconnectionTimeout
isn't really configurable for streaming right now like it should be.Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewPR-Codex overview
This PR focuses on adding a new optional parameter,
connectionTimeout
, to theEventStreamHubSubscriber
class, allowing for better control over connection timeouts.Detailed summary
connectionTimeout?: number
as an optional parameter in the constructor ofEventStreamHubSubscriber
.super
in the constructor to include the newconnectionTimeout
argument.