Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shuttle): Pipe connectionTimeout arg through EventStreamHubSubscriber #2382

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

tybook
Copy link
Contributor

@tybook tybook commented Oct 25, 2024

Why is this change needed?

Follow-up to #2367. I missed piping through BaseHubSubscriber's new connectionTimeout param through to EventStreamHubSubscriber, which means connectionTimeout isn't really configurable for streaming right now like it should be.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR focuses on adding a new optional parameter, connectionTimeout, to the EventStreamHubSubscriber class, allowing for better control over connection timeouts.

Detailed summary

  • Added connectionTimeout?: number as an optional parameter in the constructor of EventStreamHubSubscriber.
  • Updated the call to super in the constructor to include the new connectionTimeout argument.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

…riber

    Follow-up to farcasterxyz#2367. Missed piping through BaseHubSubscribers new `connectionTimeout` param through to EventStreamHubSubscriber.
Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: 0a46caf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/shuttle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 6:02pm

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.17%. Comparing base (1880070) to head (0a46caf).
Report is 413 commits behind head on main.

Files with missing lines Patch % Lines
packages/shuttle/src/shuttle/hubSubscriber.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2382       +/-   ##
===========================================
- Coverage   74.05%   44.17%   -29.89%     
===========================================
  Files          99      146       +47     
  Lines        9425    26276    +16851     
  Branches     2097     9335     +7238     
===========================================
+ Hits         6980    11607     +4627     
- Misses       2327    12859    +10532     
- Partials      118     1810     +1692     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanjayprabhu sanjayprabhu merged commit a9c45a3 into farcasterxyz:main Oct 28, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants