Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove temporary files after script exit #2393

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix: Remove temporary files after script exit #2393

merged 1 commit into from
Oct 31, 2024

Conversation

sds
Copy link
Member

@sds sds commented Oct 31, 2024

Why is this change needed?

We don't need to keep the temporary files around after the script has run. Remove them after script termination.

Suggested in #2356.

Merge Checklist


PR-Codex overview

This PR introduces a cleanup mechanism in the scripts/hubble.sh file to ensure that a temporary file is removed upon script exit.

Detailed summary

  • Added a trap command to remove the temporary file (tmp_file) when the script exits, ensuring no leftover files remain after execution.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ❌ Failed (Inspect) Oct 31, 2024 8:56pm

Copy link

changeset-bot bot commented Oct 31, 2024

⚠️ No Changeset found

Latest commit: deb2a99

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sds sds merged commit d971111 into main Oct 31, 2024
7 of 8 checks passed
@sds sds deleted the sds/add-trap branch October 31, 2024 20:57
@sds
Copy link
Member Author

sds commented Oct 31, 2024

No changeset since this doesn't affect the Hubble package/Docker image in any way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant