Refactor project structure #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved the check-running code into separate functions for modular design and enhanced code resuability in 'chkok.go' and 'run_modes.go' - Add option to shutdown the http server after a number of requests, useful for testing
Moved all chkok logic Go files under the internal package, as these are supposed to be used as structured body of the chkok program, not a library that needs to be exposed and imported
farzadghanei
force-pushed
the
refactor-webrunner
branch
from
1f8a3f5 to
9c4773a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved all
chkoklogic Go files under the internal package, as these are supposed to be used as structured body of thechkokprogram, not a library that needs to be exposed and imported.Rework the
httpmode away frommainpackage and extract the logic to a new runner_modes package.Also introduce a way to properly test the
httpmode usingshutdown_after_requestsconfig.