Improve default configs, allow config http responses #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
farzadghanei
commented
Apr 27, 2024
•
farzadghanei
commented
- move defaults away from runner but to the config itself, use better defaults
- allow customizing the http mode response via new configurations
- change shutting down the http server in tests, to use a signal string header instead of counting requests
- Created a new Makefile for build, test, and version control - Changed cmd/chkok.go to add Version Makefile included in the file provides an efficient way to handle common tasks from building, testing to version control.
- Added new fields (`listen_address`, `request_read_timeout`, `response_write_timeout`) to `ConfRunner` struct in `conf.go` - Altered `run_modes.go` to utilise the new fields added in `ConfRunner` for HTTP mode. It now uses these configurations if provided or defaults if not - These changes allow user to specify HTTP listen address, read timeout and write timeout in the configuration files, providing more control over the tool's behavior in HTTP mode.
- Added new function `GetConfRunner` in `internal/conf.go` to return configurations for the runner - Modified `internal/run_modes.go` to accept configurations from `GetConfRunner` These changes were made to allow more flexibility in the configuration of the runners. Instead of each running mode merging its own configuations, a merged config is passed to the running mode from the entrypoint.
Revised `run_modes.go` to stop the HTTP server if the "X-Server-Shutdown" header value matches the `shutdownSignalHeaderValue`. Now it's possible to shutdown the server based on header set in the request rather than closing after a set number of responses. This provides more efficiency and control over the server's operations.
farzadghanei
force-pushed
the
web-runner-configs
branch
from
0053639 to
d6d15fe
Compare
- Added `GetDefaultConfRunner` function to establish a base config running. - Updated tests to verify new changes. - Allow configuring responses, move defaults to config instead of the runner
farzadghanei
force-pushed
the
web-runner-configs
branch
from
d6d15fe to
adb79d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.