fix: add mapped types in TYPE_CHECKING block for all cols #17
+6
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @frankie567 👋🏻
I've been playing with fastapi-users and I have to remove unique constaint on email col due to soft deletes. Hence, I added my own email col however as I've email col like this:
'm getting error from pylance `Override type "Mapped[str]" is not the same as base type:
Hence, I added unique of
Mapped
as well.However, I can't understand why we need seperate
if TYPE_CHECKING:
? If we directly write cols like normal table it should work. If removingif TYPE_CHECKING:
we can reject this PR as problem should solve automatically as now type will be same.Big Thanks for this lib ❤️