Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade v5 #30

Merged
merged 4 commits into from
Sep 21, 2024
Merged

Upgrade v5 #30

merged 4 commits into from
Sep 21, 2024

Conversation

jean-michelet
Copy link
Contributor

Related to #27

@jean-michelet
Copy link
Contributor Author

jean-michelet commented Sep 21, 2024

Apparently, I can't request a review from you @metcoder95.
Should I ask Matteo to add you to the collaborators of this project?
Now I remember you offered to help me review my code.

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jean-michelet
Copy link
Contributor Author

I merge cause I wanr this modifications to push another PR.
Let me know if you should have done things differently and I will push the changes.

@jean-michelet jean-michelet merged commit 7e524a5 into fastify:main Sep 21, 2024
1 check passed
@jean-michelet jean-michelet deleted the upgrade-v5 branch September 21, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants