Update types #237
Closed
Update types #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for not opening an issue, i saw this while coding today and just started doing it, should i open an issue or only the pr is fine? |
Eomm
reviewed
Nov 17, 2023
types/index.test-d.ts
Outdated
| @@ -43,10 +43,6 @@ const OAuth2Options: FastifyOAuth2Options = { | |||
| credentials: credentials, | |||
| callbackUri: 'http://localhost/testOauth/callback', | |||
| callbackUriParams: {}, | |||
| generateStateFunction: () => { | |||
There was a problem hiding this comment.
it wasn't being used in any other place. Since it needs to receive a fastifyRequest, it essentially wasn't doing anything, but typescript was yelling, so I removed it!
There was a problem hiding this comment.
You still need the test for this two function.
Please update to the valid syntax.
climba03003
requested changes
Nov 17, 2023
|
is this good to go? |
|
@climba03003 are you ok the current changes? |
|
@Eomm ? |
climba03003
requested changes
Nov 23, 2023
|
Sorry for disappearing here, got a bit out of time. Will be finishing this weekend! |
|
Any updates? |
Signed-off-by: Aras Abbasi <aras.abbasi@googlemail.com>
|
Delayed to much here, might peak up on a new pr, closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring the types for a better autocomplete of functions and plugin options. The reason for the change is because of this behavior
Checklist
npm run testandnpm run benchmarkand the Code of conduct