Refactor labels used in realtime package #167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leklund Taking a different approach of smaller pull requests working towards the feature of being able to remove the |
Previously, each metric had a static list of labels to be applied. By changing this to a variable, we can now define a default set of labels plus any extra labels. These changes are preparation work for introducing a feature allowing for the removal of the `datacenter` label. Signed-off-by: Michael Lorant <michael.lorant@nine.com.au>
|
If you are happy with these results, I will put up 2 more pull requests to refactor the |
|
@mikelorant This can be closed, correct? |
|
Closing this one as an alternative approach was taken in #169. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, each metric had a static list of labels to be applied. By changing this to a variable, we can now define a default set of labels plus any extra labels.
These changes are preparation work for introducing a feature allowing for the removal of the
datacenterlabel.