-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add general transpose for vivado/vitis #1124
Conversation
c4efd51
to
cf72985
Compare
I would propose the following change with this PR since it's no longer needed:
|
This PR looks to be quite useful and I think should be quite rapidly merged, since it makes pytorch streaming models more parsable (after removing the no longer needed graceful failure, with this PR). |
Done |
For a sanity check I am rerunning the pytests, but if they pass, I suggest we merge this PR. |
Description
Add general N-dimensional transpose for vivado/vitis backend. Resource consumption validated to be unchanged for all 2/3d io_parallel Vivado/Vitis HLS (2020.1/2023.2), and 2d io_stream Vitis HLS.
For Vivado HLS there is a resource overhead for io_sream transpose 2d. Template overload is used to use the original impl for io_stream 2d.
Type of change
Tests
test/pytest/test_transpose_concat.py/test_highdim_permute
Checklist
pre-commit
on the files I edited or added.