Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual boot 7.0 and 7.1 #103

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Dual boot 7.0 and 7.1 #103

wants to merge 3 commits into from

Conversation

arielj
Copy link
Contributor

@arielj arielj commented Oct 26, 2023

Description:

This PR updates the app to use 7.0 and dual boot with 7.1.

I also updated some config files based on changes from running rails app:update

I will abide by the code of conduct.

@arielj
Copy link
Contributor Author

arielj commented Oct 26, 2023

I added a bug report in the skunk repo, it's failing because the skunk score improved #104 (not really an improvement for any particular file, but we have more files now so the average improved)

Copy link
Member

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arielj I see that the new framework defaults are commented. Shouldn't we try with new framework defaults to see if everything works as expected?

Please let me know

@arielj
Copy link
Contributor Author

arielj commented Jan 29, 2024

@arielj I see that the new framework defaults are commented. Shouldn't we try with new framework defaults to see if everything works as expected?

Please let me know

We could, it's not something required though (it could be done after the upgrade in another PR, the Rails docs recommend doing that over time and multiple deployments https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#configure-framework-defaults).

So it's not needed, but I can try that (we have to consider that there are some changes there that require extra changes, like changing the encryption key requires adding a cookie rotator that has to be removed in the future https://github.com/fastruby/skunk.fyi/pull/103/files#diff-eea1c50635a8c62e2b5a61e4e6526c06b9a172c2c7eb6e071dc4b42722b8d5f6R19-R26 )

I do think skunk.fyi is so simple that it's probably safe to just change the load_defaults line to load the 7.0 defaults and call it a day, but we do have a problem that the app is using the 6.0 defaults currently, so turning on 7.0 defaults would be also applying 6.1 defaults https://github.com/fastruby/skunk.fyi/blob/main/config/application.rb#L25

maybe we need another PR/story to upgrade the defaults gradually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants