Add backwards compatible type params for HTTPRequest and HTTPStreamRequest #289
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data types for
HTTPRequest
andHTTPStreamRequest
are hardcoded today. Because of #288, we need to support generics fordata
. They default to backwards compatible types.Description
This PR makes the following backwards compatible changes:
HTTPRequest
now takes a type parameter that is applied todata
. It defaults toQueryRequest
.HTTPStreamRequest
now takes a type parameter that is applied todata
. It defaults toStreamRequest
.Motivation and context
To take advantage of
HTTPClient.request
against endpoints other than/query/v1
, we need to support payloads other thanQueryRequest
. While we don't have an immediate use case for extendingHTTPStreamRequest
, I would argue it makes sense to keep the approaches the same across our two primary request types (call/response and streaming).How was the change tested?
No tests were added for this specific change. If all existing tests pass, this is a safe change. The underlying data types are never referred to or accessed directly within the client.
Screenshots (if appropriate):
N/A
Change types
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.