Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sleeps from streaming tests #193

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Remove sleeps from streaming tests #193

merged 1 commit into from
Sep 24, 2024

Conversation

erickpintor
Copy link
Contributor

Description

Remove sleeps from streaming tests.

Motivation and context

Sleeps were added to patch over a long fixed bug. Time coordination should not be necessary and failures should be investigated further.

How was the change tested?

Unit tests changed ran many times locally without failures.

Screenshots (if appropriate):

NA

Change types

    • Bug fix (non-breaking change that fixes an issue)
    • New feature (non-breaking change that adds functionality)
    • Breaking change (backwards-incompatible fix or feature)

Checklist:

    • My code follows the code style of this project.
    • My change requires a change to Fauna documentation.
    • My change requires a change to the README, and I have updated it accordingly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@erickpintor
Copy link
Contributor Author

I've managed to get a failure locally. It turns out the coordination is not between Fauna and the driver but between the two threads running in the same test case. We can at least turn it into a threading.Barrier to make tests run deterministically and faster.

@erickpintor erickpintor merged commit b70d00a into main Sep 24, 2024
6 checks passed
@erickpintor erickpintor deleted the nosleep branch September 24, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants