-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add debug logging #198
Conversation
08ff03b
to
0e51bba
Compare
0e51bba
to
1ee1633
Compare
69c0a07
to
c888a53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README looks good aside from a minor typo (in under
).
I left some other suggestions but feel free to take or leave those as you see fit. Thanks!
Co-authored-by: James Rodewig <james.rodewig@fauna.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Narrow +1 on the README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO if we're going to exclude auth headers, we should do it consistently across all the drivers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with it, but want to make sure @findgriffin has a chance to ACK too since there's an open discussion going on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with reservations :)
Description
Enable debug logging with:
Motivation and context
BT-5156
When users encounter unexpected behaviors they may need to inspect raw headers and data.
Why not a special env var named FAUNA_DEBUG? While we're doing this in other languages, it breaks a standard within Python that is intended to be configurable by logging namespace. Following the standard enables library consumers maximum control over logging within their applications without special treatment.
How was the change tested?
httpcore
andhttpx
debug logs are excluded below for clarity.Screenshots (if appropriate):
Change types
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.