Update README for CLI v4 beta #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrodewig
force-pushed
the
update-cli-v4
branch
from
cc5c954 to
8a3252d
Compare
jrodewig
force-pushed
the
update-cli-v4
branch
from
8a3252d to
3636365
Compare
findgriffin
requested changes
Dec 20, 2024
setup.sh
Outdated
Comment on lines
1
to
7
| fauna query --input seed/categories.fql --secret "$FAUNA_SECRET" | ||
| echo -e "\n\n" | ||
| fauna query --input seed/customers.fql --secret "$FAUNA_SECRET" | ||
| echo -e "\n\n" | ||
| fauna query --input seed/products.fql --secret "$FAUNA_SECRET" | ||
| echo -e "\n\n" | ||
| fauna query --input seed/orders.fql --secret "$FAUNA_SECRET" |
There was a problem hiding this comment.
You probably didn't see it, but I put a new file test/setup.sh that somewhat duplicates this file, I think we need to rename that file, or this file. Maybe we could rename this one seed.sh and put this script along with setup.sh and validate.sh in a directory called scripts?
There was a problem hiding this comment.
Thanks! I did the following:
- Renamed this file to
seed.shand placed it in/scripts. - Moved
/test/*files over to/scripts. - Updated references in
test.yml - Deleted some redundant data in
/seed/*.jsonfiles.
There's some additional work needed to update test.yml to the CLI v4 beta. Once that's done, we can just call seed.sh from setup.sh. However, that's a bit beyond the scope of this PR. I can tackle that in a separate PR if wanted.
Feel free to push changes to this PR/branch. Appreciate you taking a look!
findgriffin
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.seed.shfile so users can add test data.fqlfiles used for test data