Skip to content

Commit

Permalink
protoboard: add TODO for BlackBoardInterfaceListener conversion
Browse files Browse the repository at this point in the history
  • Loading branch information
vmatare committed Dec 4, 2019
1 parent f13e939 commit 6c9a47e
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/libs/protoboard/blackboard_manager.h
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,12 @@ class bb_iface_manager
{
blackboard_ = blackboard;
interface_ = blackboard_->open_for_writing<IfaceT>(iface_id_for_type<IfaceT>().c_str());
waker_ = new fawkes::BlackBoardOnMessageWaker(blackboard, interface_, thread);

// TODO: This rather unspecific waker just triggers a loop(), so we need to go over all the interfaces
// each time and check where there's a message in the queue. This should be converted to a
// BlackBoardInterfaceListener, which calls a specific method and passes in the affected interface
// right away. That should allow significant simplification of all this template hackery.
waker_ = new fawkes::BlackBoardOnMessageWaker(blackboard, interface_, thread);
}

/// Cleanup.
Expand Down

0 comments on commit 6c9a47e

Please sign in to comment.