fix: integrity error using DUC and improve auditing and logging #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When handing a payment, and double checking that the payment as been payed on PayGate, the card number `CARD_MASKED_PAN` is empty/null for DUC payments. The card number nullable crashes Ecommerce. fixes #15
Record PayGate calls specific to a Basket as a processor response, so we can better audit and trace all calls to PayGate as a fake response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: improve auditing and logging
Record PayGate calls specific to a Basket as a processor response,
so we can better audit and trace all calls to PayGate as a fake
response.
feat: add more logging
fix: double raising error
fix: integrity error using DUC
When handing a payment, and double checking that the
payment as been payed on PayGate, the card number
CARD_MASKED_PANis empty/null for DUC payments.The card number nullable crashes Ecommerce.