fix: github actions release flow #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@igobranco Can you review this with me? |
- remove the semantic release code and replace it with repo tagging. - when the `package.json` version is updated, a new npm package is generated.
sandroscosta
force-pushed
the
sandroscosta/actions-publish
branch
from
15966f8
to
6595887
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package.jsonversion is updated, a new npm package is generated.My observation is that we don't need the confusion that semantic-release creates. It's better to be more descriptive about our releases. As is, the idea is to have the major release number reflect the openedx version.
When we need to update, we just change
package.jsonand let github actions run normally.Adapted directly from https://github.com/pascalgn/npm-publish-action