Skip to content

Commit

Permalink
⬆️(global) bump docker node image to the latest minor version
Browse files Browse the repository at this point in the history
Bump docker node image to version 18.19
  • Loading branch information
igobranco committed Jan 23, 2024
1 parent 37b689b commit ad06ff0
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 16 deletions.
13 changes: 6 additions & 7 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
working_directory: ~/fun/sites/<< parameters.site >>
build-front-production:
docker:
- image: cimg/node:16.15
- image: cimg/node:18.19
parameters:
site:
type: string
Expand All @@ -70,7 +70,7 @@ jobs:
working_directory: ~/fun/sites/<< parameters.site >>/src/frontend/
check-changelog:
docker:
- image: cimg/base:2022.06
- image: cimg/base:2024.01
parameters:
site:
type: string
Expand Down Expand Up @@ -98,7 +98,7 @@ jobs:
docker:
- environment:
RICHIE_SITE: << parameters.site >>
image: cimg/base:2022.06
image: cimg/base:2024.01
parameters:
image_name:
type: string
Expand All @@ -108,8 +108,7 @@ jobs:
- checkout
- generate-version-file:
site: << parameters.site >>
- setup_remote_docker:
version: 19.03.13
- setup_remote_docker
- run:
command: make env.d/aws && make build
name: Build docker images
Expand Down Expand Up @@ -242,7 +241,7 @@ jobs:
working_directory: ~/fun
lint-front:
docker:
- image: cimg/node:16.15
- image: cimg/node:18.19
parameters:
site:
type: string
Expand Down Expand Up @@ -281,7 +280,7 @@ jobs:
working_directory: ~/fun
no-change:
docker:
- image: cimg/base:2022.06
- image: cimg/base:2024.01
steps:
- run: echo "Everything is up-to-date ✅"
working_directory: ~/fun
Expand Down
5 changes: 2 additions & 3 deletions .circleci/src/jobs/@docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ hub:
image_name:
type: string
docker:
- image: cimg/base:2022.06
- image: cimg/base:2024.01
environment:
RICHIE_SITE: << parameters.site >>
working_directory: ~/fun
Expand All @@ -17,8 +17,7 @@ hub:
- generate-version-file:
site: << parameters.site >>
# Activate docker-in-docker (with layers caching enabled)
- setup_remote_docker:
version: 19.03.13
- setup_remote_docker
- run:
name: Build docker images
command: make env.d/aws && make build
Expand Down
4 changes: 2 additions & 2 deletions .circleci/src/jobs/@frontend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ build-front-production:
site:
type: string
docker:
- image: cimg/node:16.15
- image: cimg/node:18.19
working_directory: ~/fun/sites/<< parameters.site >>/src/frontend/
steps:
- checkout:
Expand Down Expand Up @@ -33,7 +33,7 @@ lint-front:
site:
type: string
docker:
- image: cimg/node:16.15
- image: cimg/node:18.19
working_directory: ~/fun/sites/<< parameters.site >>/src/frontend/
steps:
- checkout:
Expand Down
4 changes: 2 additions & 2 deletions .circleci/src/jobs/@project.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ check-changelog:
site:
type: string
docker:
- image: cimg/base:2022.06
- image: cimg/base:2024.01
working_directory: ~/fun
steps:
- checkout
Expand Down Expand Up @@ -89,7 +89,7 @@ lint-changelog:
# Check that the CHANGELOG max line length does not exceed 80 characters
no-change:
docker:
- image: cimg/base:2022.06
- image: cimg/base:2024.01
working_directory: ~/fun
steps:
- run: echo "Everything is up-to-date ✅"
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ ARG DOCKER_USER=10000
FROM python:3.10-buster as base

# ---- front-end builder image ----
FROM node:16.15 as front-builder
FROM node:18.19 as front-builder

ARG SITE

Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ services:
image: jwilder/dockerize

node:
image: node:16.15
image: node:18.19
working_dir: /app/src/frontend
user: "${DOCKER_USER:-1000}"
volumes:
Expand Down
4 changes: 4 additions & 0 deletions sites/nau/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

### Changed

- ⬆️(global) upgrade node to v18.19

## [1.21.0] - 2023-12-06

### Added
Expand Down
1 change: 1 addition & 0 deletions sites/nau/src/backend/templates/richie/base.html
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
<!-- bullshit -->
{% endblock meta_favicons %}

<!-- test -->
{% block branding_topbar %}
<img src="{% static "richie/images/logo_nau_by_fccn.svg" %}" class="topbar__logo" alt="{{ SITE.name }}">
{% endblock branding_topbar %}
Expand Down

0 comments on commit ad06ff0

Please sign in to comment.