Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Richie to 2.28.0 #243

Merged
merged 5 commits into from
Jun 14, 2024
Merged

Conversation

sandroscosta
Copy link
Contributor

@sandroscosta sandroscosta commented Jun 12, 2024

  • Upgrade Python and NodeJS circleCI requirements
  • Upgrade Python requirements and NodeJS requirements for Docker
  • Import cunningham design system
  • Update CSS
  • Upgrade to 2.26.0
  • Upgrade to 2.28.0 to fix CDN cache

@sandroscosta sandroscosta self-assigned this Jun 12, 2024
@sandroscosta sandroscosta force-pushed the sandroscosta/issues/240/upgrade_2_26_0 branch 2 times, most recently from 90bb8e9 to 2b43f2a Compare June 12, 2024 14:13
@sandroscosta sandroscosta marked this pull request as draft June 12, 2024 14:22
@sandroscosta sandroscosta force-pushed the sandroscosta/issues/240/upgrade_2_26_0 branch 8 times, most recently from fb339a5 to 6be7879 Compare June 12, 2024 21:29
Upgrade Python and Nodejs
Upgrade Python to 3.11 and NodeJS to 20.13
Upgrade Richie to 2.26.0. Add cunningham
tokens and fix small css issues with organization cards.
Fix pylint errors on the backend, including tests.
@sandroscosta sandroscosta force-pushed the sandroscosta/issues/240/upgrade_2_26_0 branch from 6be7879 to 6506cff Compare June 14, 2024 09:17
@sandroscosta sandroscosta changed the title Upgrade Richie to 2.26.0 Upgrade Richie to 2.28.0 Jun 14, 2024
@sandroscosta sandroscosta marked this pull request as ready for review June 14, 2024 12:51
@igobranco
Copy link
Member

A very small style problem.

Normal:
image

On hover, the edges of the button isn't rounded equally.
image

@sandroscosta
Copy link
Contributor Author

It is a "Cunningham" style decision made by FUN https://cunningham.education/storybook/?path=/docs/components-button--docs

I can revert it by overriding the css.

@igobranco
Copy link
Member

@sandroscosta ok, no problem. Just launch what we have. I thought that it was a bug on our side.

Copy link
Member

@igobranco igobranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

@sandroscosta sandroscosta merged commit 827a270 into master Jun 14, 2024
10 of 11 checks passed
@sandroscosta sandroscosta linked an issue Jun 15, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade NAU site to use Node 20
2 participants