From 52fa22ff1a075df68cdda9fac8eb24ef7d9e2028 Mon Sep 17 00:00:00 2001
From: Qijia Liu <liumeo@pku.edu.cn>
Date: Wed, 1 Jan 2025 17:50:24 -0500
Subject: [PATCH] Support switch between debug and release (#216)

---
 .github/workflows/ci.yml                 |   2 +
 .gitignore                               |   1 -
 assets/update.sh                         |   6 ++-
 assets/zh-Hans.lproj/Localizable.strings | Bin 22560 -> 23262 bytes
 logging/CMakeLists.txt                   |   9 ++--
 logging/debug.swift                      |   1 +
 logging/debug.swift.in                   |   1 -
 logging/release.swift                    |   1 +
 src/CMakeLists.txt                       |   5 ++
 src/config/about.swift                   |  65 +++++++++++++++++++----
 src/config/installer.swift               |  14 +++--
 src/config/plugin.swift                  |   3 +-
 src/fcitx.cpp                            |  14 ++---
 src/fcitx.h                              |   2 +-
 14 files changed, 93 insertions(+), 31 deletions(-)
 create mode 100644 logging/debug.swift
 delete mode 100644 logging/debug.swift.in
 create mode 100644 logging/release.swift

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 02b34396..e966dccf 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -68,8 +68,10 @@ jobs:
 
       - name: Build
         run: |
+          # Don't log key on any CI artifact.
           cmake -B build -G Ninja \
             -DCMAKE_Swift_COMPILER=`which swiftc` \
+            -DVERBOSE_LOGGING=OFF \
             -DCMAKE_OSX_ARCHITECTURES=${{ matrix.arch }} \
             -DCMAKE_BUILD_TYPE=${{ matrix.type }}
           cmake --build build
diff --git a/.gitignore b/.gitignore
index ca42552f..3daa43e9 100644
--- a/.gitignore
+++ b/.gitignore
@@ -8,5 +8,4 @@ build
 assets/en.lproj/Localizable.strings
 assets/po/base.pot
 meta.swift
-debug.swift
 *~
diff --git a/assets/update.sh b/assets/update.sh
index edb5aa2b..ee807ab7 100755
--- a/assets/update.sh
+++ b/assets/update.sh
@@ -7,7 +7,11 @@ INSTALL_DIR="/Library/Input Methods"
 APP_DIR="$INSTALL_DIR/Fcitx5.app"
 RESOURCES_DIR="$APP_DIR/Contents/Resources"
 
-rm -rf "$APP_DIR/Contents/*"
+# Don't remove files that must exist (which will be overwritten) as that will put Fcitx5 in a registered-but-not-listed state.
+rm -rf "$APP_DIR"/Contents/{bin,lib,share,Resources}
+if ls "$APP_DIR"/Contents/MacOS/Fcitx5.*; then # Debug symbols
+    rm -rf "$APP_DIR"/Contents/MacOS/Fcitx5.*
+fi
 tar xjvf "$tar_ball" -C "$INSTALL_DIR"
 rm -f "$tar_ball"
 xattr -dr com.apple.quarantine "$APP_DIR"
diff --git a/assets/zh-Hans.lproj/Localizable.strings b/assets/zh-Hans.lproj/Localizable.strings
index b0fe57a7772b04d6061580b00f8528240f1909b4..a8213e14668d641b0039ab186031bbe869939586 100644
GIT binary patch
delta 378
zcmZ3mf$`o}#tnPKrBfM_7)lw^8I%|l7;J%9iNS>dDmK|rCUWyGaUT=gV1{yrOokGM
zWQGi&k`jh|APHB7q?J7=DcK+hSx$k$V{)NqbUmj26qq$Yv+^187;+dYfvil1G$82)
zw5bHhu3#_)@{$>f7!nzZfp(_?Nd+J~k0Av}R|55w0_k$FNC}VyaT!Qm4nqNu54Xde
zK@Z89NBx51`C}OUUFT`WHs_VaiTJHZuutSq^bcMcG%5LMx^L2yIILbNnyla+V}j|I
gAh3<8U{|IhSp+iVUf9K8=D5iR<fAsT`AG2q05Eq_NdN!<

delta 19
bcmcb&m2tra#tnPKHycTKnQT7dC&dE*Sn3DQ

diff --git a/logging/CMakeLists.txt b/logging/CMakeLists.txt
index c07cbabf..97e02441 100644
--- a/logging/CMakeLists.txt
+++ b/logging/CMakeLists.txt
@@ -1,8 +1,7 @@
+set(LOGGING_SRCS logging.swift)
 if(CMAKE_BUILD_TYPE MATCHES "Debug")
-    set(IS_DEBUG true)
+    list(APPEND LOGGING_SRCS debug.swift)
 else()
-    set(IS_DEBUG false)
+    list(APPEND LOGGING_SRCS release.swift)
 endif()
-configure_file(debug.swift.in ${CMAKE_CURRENT_SOURCE_DIR}/debug.swift @ONLY)
-
-add_library(Logging STATIC logging.swift debug.swift)
+add_library(Logging STATIC ${LOGGING_SRCS})
diff --git a/logging/debug.swift b/logging/debug.swift
new file mode 100644
index 00000000..f2f28001
--- /dev/null
+++ b/logging/debug.swift
@@ -0,0 +1 @@
+public let isDebug = true
diff --git a/logging/debug.swift.in b/logging/debug.swift.in
deleted file mode 100644
index 7bd391da..00000000
--- a/logging/debug.swift.in
+++ /dev/null
@@ -1 +0,0 @@
-let isDebug = @IS_DEBUG@
diff --git a/logging/release.swift b/logging/release.swift
new file mode 100644
index 00000000..208faa5d
--- /dev/null
+++ b/logging/release.swift
@@ -0,0 +1 @@
+public let isDebug = false
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index b5e793d5..75a6f98f 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -16,6 +16,11 @@ add_library(Fcitx5Objs STATIC
     config/config.cpp
 )
 
+option(VERBOSE_LOGGING "Enable verbose logging" ON)
+if(VERBOSE_LOGGING)
+    target_compile_definitions(Fcitx5Objs PRIVATE VERBOSE_LOGGING)
+endif()
+
 target_link_libraries(Fcitx5Objs
     SwiftyJSON
     SwiftFrontend
diff --git a/src/config/about.swift b/src/config/about.swift
index 7c8424cb..6bb934e6 100644
--- a/src/config/about.swift
+++ b/src/config/about.swift
@@ -59,6 +59,7 @@ struct AboutView: View {
   @State private var showCheckFailed = false
   @State private var showDownloadFailed = false
   @State private var showInstallFailed = false
+  @State private var showSwitchToDebug = false
   @State private var confirmUninstall = false
   @State private var removeUserData = false
   @State private var uninstalling = false
@@ -77,7 +78,13 @@ struct AboutView: View {
         .font(.title)
 
       Spacer().frame(height: gapSize)
-      Text(arch)
+
+      HStack {
+        Text(arch)
+        if isDebug {
+          Text("Debug")
+        }
+      }
 
       Spacer().frame(height: gapSize)
       urlButton(String(commit.prefix(7)), sourceRepo + "/commit/" + commit)
@@ -110,7 +117,7 @@ struct AboutView: View {
           if viewModel.state == .notChecked {
             checkUpdate()
           } else if viewModel.state == .available {
-            update()
+            update(debug: isDebug)
           }
         } label: {
           if viewModel.state == .notChecked || viewModel.state == .upToDate {
@@ -139,7 +146,7 @@ struct AboutView: View {
             VStack {
               Text("Update available")
               Button {
-                update()
+                update(debug: isDebug)
               } label: {
                 Text("Update now")
               }.buttonStyle(.borderedProminent)
@@ -151,11 +158,50 @@ struct AboutView: View {
             }.padding()
           }
 
+        if isDebug {
+          Button {
+            update(debug: false)
+          } label: {
+            Text("Switch to Release")
+          }.disabled(
+            viewModel.state == .downloading || viewModel.state == .installing
+          )
+        } else {
+          Button {
+            showSwitchToDebug = true
+          } label: {
+            Text("Switch to Debug")
+          }.disabled(
+            viewModel.state == .downloading || viewModel.state == .installing
+          ).sheet(
+            isPresented: $showSwitchToDebug
+          ) {
+            VStack {
+              Text("Switch to debug only if Fctix5 crashes and you want to help debug.")
+              HStack {
+                Button {
+                  showSwitchToDebug = false
+                } label: {
+                  Text("Cancel")
+                }
+                Button {
+                  update(debug: true)
+                  showSwitchToDebug = false
+                } label: {
+                  Text("OK")
+                }.buttonStyle(.borderedProminent)
+              }
+            }.padding()
+          }
+        }
+
         Button {
           confirmUninstall = true
         } label: {
           Text("Uninstall")
-        }.sheet(
+        }.disabled(
+          viewModel.state == .downloading || viewModel.state == .installing
+        ).sheet(
           isPresented: $confirmUninstall
         ) {
           VStack {
@@ -272,15 +318,16 @@ struct AboutView: View {
     }.resume()
   }
 
-  func update() {
+  func update(debug: Bool) {
     viewModel.state = .downloading
     checkPluginUpdate({ success, nativePlugins, dataPlugins in
-      let updater = Updater(main: true, nativePlugins: nativePlugins, dataPlugins: dataPlugins)
+      let updater = Updater(
+        main: true, debug: debug, nativePlugins: nativePlugins, dataPlugins: dataPlugins)
       updater.update(
         // Install plugin in a best-effort manner. No need to check plugin status.
         onFinish: { result, _, _ in
           if result {
-            install()
+            install(debug: debug)
           } else {
             viewModel.state = .available
             showDownloadFailed = true
@@ -292,7 +339,7 @@ struct AboutView: View {
     })
   }
 
-  func install() {
+  func install(debug: Bool) {
     viewModel.state = .installing
     let conditions = NSMutableDictionary()
     conditions.setValue("com.apple.keylayout.ABC", forKey: kTISPropertyInputSourceID as String)
@@ -303,7 +350,7 @@ struct AboutView: View {
         TISSelectInputSource(inputSource)
       }
     }
-    let path = cacheDir.appendingPathComponent(mainFileName).localPath()
+    let path = cacheDir.appendingPathComponent(debug ? mainDebugFileName : mainFileName).localPath()
     // Necessary to put it in background, otherwise sudo UI will hang if it has been canceled once.
     DispatchQueue.global().async {
       if !sudo("update", path, updateLog) {
diff --git a/src/config/installer.swift b/src/config/installer.swift
index 88d7ccee..0bd74cf7 100644
--- a/src/config/installer.swift
+++ b/src/config/installer.swift
@@ -2,7 +2,7 @@ import Foundation
 import Logging
 
 let mainFileName = "Fcitx5-\(arch).tar.bz2"
-private let mainAddress = "\(sourceRepo)/releases/download/latest/\(mainFileName)"
+let mainDebugFileName = "Fcitx5-\(arch)-debug.tar.bz2"
 let pluginBaseAddress =
   "https://github.com/fcitx-contrib/fcitx5-plugins/releases/download/macos/"
 
@@ -56,12 +56,14 @@ private func extractPlugin(_ plugin: String, native: Bool) -> Bool {
 }
 
 class Updater {
-  private var main: Bool
-  private var nativePlugins: [String]
-  private var dataPlugins: [String]
+  private let main: Bool
+  private let debug: Bool
+  private let nativePlugins: [String]
+  private let dataPlugins: [String]
 
-  init(main: Bool, nativePlugins: [String], dataPlugins: [String]) {
+  init(main: Bool, debug: Bool, nativePlugins: [String], dataPlugins: [String]) {
     self.main = main
+    self.debug = debug
     self.nativePlugins = nativePlugins
     self.dataPlugins = dataPlugins
   }
@@ -70,6 +72,8 @@ class Updater {
     onFinish: @escaping (Bool, [String: Bool], [String: Bool]) -> Void,
     onProgress: ((Double) -> Void)? = nil
   ) {
+    let mainAddress =
+      "\(sourceRepo)/releases/download/latest/\(self.debug ? mainDebugFileName : mainFileName)"
     let downloader = Downloader(
       nativePlugins.map({ getAddress($0, native: true) })
         + dataPlugins.map({ getAddress($0, native: false) }) + (main ? [mainAddress] : [])
diff --git a/src/config/plugin.swift b/src/config/plugin.swift
index 94f441cd..a87438e8 100644
--- a/src/config/plugin.swift
+++ b/src/config/plugin.swift
@@ -222,7 +222,8 @@ struct PluginView: View {
     let selectedPlugins = selectedAvailable
     selectedAvailable.removeAll()
 
-    let updater = Updater(main: false, nativePlugins: nativeAvailable, dataPlugins: dataAvailable)
+    let updater = Updater(
+      main: false, debug: false, nativePlugins: nativeAvailable, dataPlugins: dataAvailable)
     updater.update(
       onFinish: { _, nativeResults, dataResults in
         processing = false
diff --git a/src/fcitx.cpp b/src/fcitx.cpp
index 47d0494b..6d301329 100644
--- a/src/fcitx.cpp
+++ b/src/fcitx.cpp
@@ -38,7 +38,7 @@ Fcitx &Fcitx::shared() {
 }
 
 Fcitx::Fcitx() {
-    setupLog(true);
+    setupLog();
     setupEnv();
 }
 
@@ -99,15 +99,15 @@ void Fcitx::teardown() {
     instance_.reset();
 }
 
-void Fcitx::setupLog(bool verbose) {
+void Fcitx::setupLog() {
     static native_streambuf log_streambuf;
     static std::ostream stream(&log_streambuf);
     fcitx::Log::setLogStream(stream);
-    if (verbose) {
-        fcitx::Log::setLogRule("*=5,notimedate");
-    } else {
-        fcitx::Log::setLogRule("notimedate");
-    }
+#ifdef VERBOSE_LOGGING
+    fcitx::Log::setLogRule("*=5,notimedate");
+#else
+    fcitx::Log::setLogRule("*=4,notimedate");
+#endif
 }
 
 void Fcitx::setupEnv() {
diff --git a/src/fcitx.h b/src/fcitx.h
index 4897705a..602e2482 100644
--- a/src/fcitx.h
+++ b/src/fcitx.h
@@ -30,7 +30,7 @@ class Fcitx final {
     fcitx::MacosFrontend *frontend();
 
 private:
-    void setupLog(bool verbose);
+    void setupLog();
     void setupEnv();
     void setupInstance();