Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional minimap2 parameters that are useful for HiFi data #29

Open
fedarko opened this issue Jun 14, 2022 · 0 comments
Open

Additional minimap2 parameters that are useful for HiFi data #29

fedarko opened this issue Jun 14, 2022 · 0 comments
Labels
backburner Low-priority things that are still good to keep track of enhancement New feature or request

Comments

@fedarko
Copy link
Owner

fedarko commented Jun 14, 2022

The set that flye uses may be a good reference. In particular, -L and -Q are both no-brainers that would be good to add in.

https://github.com/fenderglass/Flye/blob/192de706210a96768eb69eed778fe1b81e887165/flye/polishing/alignment.py#L246-L267

@fedarko fedarko added the enhancement New feature or request label Jun 14, 2022
@fedarko fedarko changed the title Additional minimap2 parameters that are useful for long data Additional minimap2 parameters that are useful for HiFi data Jun 14, 2022
fedarko added a commit that referenced this issue Sep 11, 2022
Closes #23 -- the user can now specify the exact preset themselves.

Closes #17 -- piping is now handled by the shell, rather than Python,
which should remove the Python-specific piping memory problems. We
could add explicit -o at every step if desired, but I think it should
be fine.

Partial work on #21: it would still be nice to add an "early warning
system" for massive FASTA files.

Parital work on #29: users can now add these extra parameters
themselves if desired. It might be worth adding new default
parameters, but that's a less urgent question.
@fedarko fedarko added the backburner Low-priority things that are still good to keep track of label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backburner Low-priority things that are still good to keep track of enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant