Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The passband used in generating the comparison list should maybe match the image passband #441

Open
mwcraig opened this issue Sep 8, 2024 · 0 comments · May be fixed by #460
Open

The passband used in generating the comparison list should maybe match the image passband #441

mwcraig opened this issue Sep 8, 2024 · 0 comments · May be fixed by #460
Labels
bug Something isn't working
Milestone
2.0.0-beta

Comments

@mwcraig
Copy link
Contributor

mwcraig commented Sep 8, 2024

Right now the passband used for selecting comparison stars is set here. It should probably actually be related to the passband of the image loaded into the comparison viewer.

Fixing this entails change something in comparison_functions, I think, not something in mag_scale.
@mwcraig mwcraig added the bug Something isn't working label Sep 8, 2024
@mwcraig mwcraig added this to the 2.0.0-beta milestone Sep 8, 2024
@mwcraig mwcraig mentioned this issue Sep 8, 2024
Merged
@mwcraig mwcraig linked a pull request Oct 6, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.0.0-beta
Development

Successfully merging a pull request may close this issue.

Select passband for comparisons based on image passband mwcraig/stellarphot
1 participant
@mwcraig