Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two tests break in photutils 2 #477

Open
mwcraig opened this issue Oct 27, 2024 · 0 comments
Open

Two tests break in photutils 2 #477

mwcraig opened this issue Oct 27, 2024 · 0 comments
Labels
bug Something isn't working
Milestone
2.0.0-beta

Comments

@mwcraig
Copy link
Contributor

mwcraig commented Oct 27, 2024

Two of our tests break in photutils>=2:

FAILED ../../.tox/test-phot2/lib/python3.11/site-packages/stellarphot/photometry/tests/test_profiles.py::TestCenter::test_find_center_no_noise_good_guess - AssertionError:
FAILED ../../.tox/test-phot2/lib/python3.11/site-packages/stellarphot/photometry/tests/test_profiles.py::TestRadialProfile::test_radial_profile_with_background - AssertionError:

See this PR check for the full traceback.

Will pin the photutils version for now, but this should get a proper fix eventually.
@mwcraig mwcraig added the bug Something isn't working label Oct 27, 2024
@mwcraig mwcraig added this to the 2.0.0-beta milestone Oct 27, 2024
mwcraig added a commit to mwcraig/stellarphot that referenced this issue Oct 27, 2024
@mwcraig
Pin photutils version
b9bf579 
Version 2.0 introduced some kind of change that broke a couple of our
tests. See feder-observatory#477 for more information.
@mwcraig mwcraig mentioned this issue Oct 27, 2024
Merged
@mwcraig mwcraig changed the title Two test break in phututils 2 Two tests break in phututils 2 Oct 30, 2024
@mwcraig mwcraig changed the title Two tests break in phututils 2 Two tests break in photutils 2 Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.0.0-beta
Development

No branches or pull requests
1 participant
@mwcraig