Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dictionaries needed for testing to new file #466

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

mwcraig
Copy link
Contributor

@mwcraig mwcraig commented Oct 7, 2024

This ensures that we can get at those constants without having to have test dependencies (e.g. pytest) installed.

Fixes #465

This ensures that we can get at those constants without having to have
test dependencies (e.g. pytest) installed.
@mwcraig mwcraig added this to the 2.0.0-beta milestone Oct 7, 2024
@mwcraig mwcraig requested a review from JuanCab October 7, 2024 22:48
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.40%. Comparing base (7f6ab4c) to head (2ae556c).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #466      +/-   ##
==========================================
+ Coverage   80.32%   80.40%   +0.07%     
==========================================
  Files          30       31       +1     
  Lines        3949     3960      +11     
==========================================
+ Hits         3172     3184      +12     
+ Misses        777      776       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JuanCab JuanCab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple and good. Just curious, why the move to settings.constants if (I assume) these dicts are only used for testing. I see the stated reason about wanting to access without pytest, but I assume that only has to do with the fact there are pytest commands in the tests.test_models file... why change the directory as well?

@mwcraig
Copy link
Contributor Author

mwcraig commented Oct 8, 2024

I think, though I haven't checked, that putting it in test might have required the test imports? Not actually positive about that. I was inspired by a similar thing in ipyautoui...

@mwcraig mwcraig merged commit 14ab32e into feder-observatory:main Oct 8, 2024
18 checks passed
@mwcraig mwcraig deleted the fix-465 branch October 8, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running stellarphot now requires that pytest be installed 🤦‍♂️
2 participants